Repository navigation
Conversation
The OIDC token is fetched with a single request, so one 5xx from GitHub's token service fails the whole upload after the screenshots are taken. We saw a 503 on a push to the default branch while GitHub reported no incident and a concurrent build got its token. Retry a 5xx three times with p-retry's default backoff, as apiFetch does for the Argos API. GitHub's @actions/core retries 502, 503 and 504 from this endpoint too. A 4xx still fails at once, since a retry would not change it. Assisted-by: Claude <noreply@anthropic.com>
kasperg
force-pushed
the
fix/retry-github-oidc-token
branch
from
November 11, 2026 09:35
9954482 to
35cff05
Compare
kasperg
marked this pull request as ready for review
November 11, 2026 09:38
4 of 6 tasks
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
An upload authenticated with GitHub Actions OIDC fails if GitHub's token service answers a single request with a server error. We hit this on a push to
main: the tests passed, then the upload stopped withFailed to fetch GitHub Actions OIDC token: 503. GitHub reported no incident at the time, and a pull request build uploading at the same time got its token.fetchOidcTokennow retries a 5xx response three times with p-retry's default backoff (1, 2 and 4 seconds), asapiFetchdoes for Argos's own API. GitHub's@actions/corealso retries 502, 503 and 504 from this endpoint (oidc-utils.ts). A 4xx is still reported at once, since a retry would not change it.Type of changes
bugChecklist
Optional checks:
Further comments
@actions/coreretries up to 10 times, but from 10 ms doubling to a 5.12 s cap, which waits about 10 s in all. Three retries from 1 s followapiFetchand wait 7 s in all, so both give up within seconds of each other.retries: 10, minTimeout: 10, maxTimeout: 5120would match@actions/coreexactly, if you prefer that.A failed build on the default branch hurts more than a failed pull request build: that commit gets no baseline, so the branches cut from it are compared with an older commit and report changes they did not make.